So you want to contribute to CFWheels? (Documentation )
In the first post of "So you want to contribute to CFWheels", we created a free Github account and forked the CFWheels repo. This gave us our own repo we can change. We added a readme file, then sent a pull request to CFWheels. In this post, we will cover how to help CFWheels by contributing documentation.
Before we make our contibution to the documentation, we should mention how the api documentation is generated. Wheels uses the hint attribute of cffunction and cfargument to generate the descriptions. Lets look at belongsTo documentation. See the descriptions? These are hint parameters in the actual code.
We will add a helpful addition to a Wheels function parameters's description. I was working on the many-to-many relationship and using the hasManyCheckBox() in a form. I was having problems with the keys parameter. The description for keys said "Primary keys associated with this form field." After reading the Nest Properties chapter, I found a gem stating "Note that these keys should be listed in the order that they appear in the database table." Wouldn't it be great if this gem was in the keys() parameter description? Let's add it and submit a pull request for CFWheels to consider adding it to their code.
Now since we understand how Wheels generates its document, we'll make a contribute to the Wheels project
Within an editor of your choice, open the Wheels folder we checkouted in part 1. We'll search for "hasManyCheckBox".
This will find 3 files:
After reviewing them quickly,
formsassociation.cfm has the
<cffunction name="hasManyCheckBox" returntype="string" access="public" output="false" hint="Used as a shortcut to output the proper form elements for an association. Note: Pass any additional arguments like `class`, `rel`, and `id`, and the generated tag will also include those values as HTML attributes."
<!--- Show check boxes for associating authors with the current book --->
categories="view-helper,forms-association" chapters="nested-properties" functions="hasMany,hasManyRadioButton,includedInObject,nestedProperties">
<cfargument name="objectName" type="string" required="true" hint="See documentation for @hasManyRadioButton." />
<cfargument name="association" type="string" required="true" hint="See documentation for @hasManyRadioButton." />
<cfargument name="keys" type="string" required="true" hint="See documentation for @hasManyRadioButton." />
<cfreturn loc.returnValue />
The keys cfargument says "see @hasManyRadioButton" which is another function in this file which has:
<cfargument name="keys" type="string" required="true" hint="Primary keys associated with this form field." />
We will add "Note that these keys should be listed in the order that they appear in the database table." to this hint.
<cfargument name="keys" type="string" required="true" hint="Primary keys associated with this form field. Note that these keys should be listed in the order that they appear in the database table." />
But first we will need to create a topic branch. So open our git bash and run these commands:
git push origin new-master:hasmanycheckbox;
git checkout -t origin/hasmanycheckbox;
We created a new topic branch for our change, then checked it out. I made the change, then did a "git status" to see the changes in our folder. After that, lets run "git commit -a -m"adding better description for hasManyCheckBox"; git push;".
This command committed and added any changes to our local git repositry, then pushed them to our GitHub repo. Now we will notify Wheels with a pull request.
We will go to our CFWheels github repo. My repo is located at https://github.com/mhenke/cfwheels. Then we will change our branch using the "Switch Branches" menu option to "hasmanycheckbox" which is the topic branch we created, and select "Pull Request". Once we have filled out the title and body we can send the pull request to CFWheels.
Here is our pull request for this documentation change. So now you can help contribute to Wheels documentation. Any contribution is greatly appreciated.